> -----Original Message-----
> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com]
> Sent: Wednesday, December 6, 2017 9:18 AM
> To: Carrillo, Erik G <erik.g.carri...@intel.com>
> Cc: pbhagavat...@caviumnetworks.com; dev@dpdk.org;
> nipun.gu...@nxp.com; hemant.agra...@nxp.com
> Subject: Re: [RFC PATCH v5 1/5] eventtimer: introduce event timer adapter
>
> -----Original Message-----
> > Date: Fri, 1 Dec 2017 14:00:54 -0600
> > From: Erik Gabriel Carrillo <erik.g.carri...@intel.com>
> > To: pbhagavat...@caviumnetworks.com
> > CC: dev@dpdk.org, jerin.ja...@caviumnetworks.com,
> nipun.gu...@nxp.com,
> > hemant.agra...@nxp.com
> > Subject: [RFC PATCH v5 1/5] eventtimer: introduce event timer adapter
> > X-Mailer: git-send-email 1.7.10
> >
> > Signed-off-by: Erik Gabriel Carrillo <erik.g.carri...@intel.com>
>
> Feel free to add my Signed-off-by as this patch is mostly based on initial
> RFC.
Ok, thanks. Pavan, I'll add yours back as well... if you'd rather I don't,
just let me know.
>
> > ---
> > doc/api/doxy-api-index.md | 1 +
> > lib/librte_eventdev/Makefile | 1 +
> > lib/librte_eventdev/rte_event_timer_adapter.h | 518
> ++++++++++++++++++++++++++
> > lib/librte_eventdev/rte_eventdev.h | 4 +-
> > 4 files changed, 522 insertions(+), 2 deletions(-) create mode
> > 100644 lib/librte_eventdev/rte_event_timer_adapter.h
> >
> > + * Event timer state.
> > + */
> > +enum rte_event_timer_state {
> > + RTE_EVENT_TIMER_NOT_ARMED = 0,
> > + /**< Event timer is in not armed state.*/
> > + RTE_EVENT_TIMER_ARMED = 1,
> > + /**< Event timer successfully armed.*/
>
> How about adding a state called RTE_EVENT_TIMER_CANCELED?, Which will
> updated by the driver on rte_event_timer_arm_burst().
> This will enable application to get the state of the rte_event_timer object in
> latter time.
Good catch - I didn't realize that state had been dropped. I'll add it back in.
Thanks,
Gabriel
>
> > + RTE_EVENT_TIMER_ERROR = -1,
> > + /**< Generic event timer error.*/
> > + RTE_EVENT_TIMER_ERROR_TOOEARLY = -2,
> > + /**< Event timer timeout tick is too little to add to the adapter. */
> > + RTE_EVENT_TIMER_ERROR_TOOLATE = -3,
> > + /**< Event timer timeout tick is greater than the maximum
> timeout.*/
> > +};
> > +
> > +/**
