30/11/2017 22:55, Stephen Hemminger: > On Thu, 30 Nov 2017 22:47:20 +0100 > Thomas Monjalon <tho...@monjalon.net> wrote: > > > + for (int reg = 1; reg < 4; reg++) > > + memcpy(name + (reg - 1) * 4, ®s[reg], 4); > > + name[12] = '\0'; > > C99 style declarations are not generally used in DPDK.
True :) It will be fixed in v2. I think I should add a log somewhere at initialization in order to test this function. Do you think it deserves a table of name strings in the .h?