On Fri, Nov 24, 2017 at 03:03:52PM +0530, Akhil Goyal wrote:
> Hi Nelio,
> On 11/23/2017 3:32 PM, Nelio Laranjeiro wrote:
> > Device operation pointers should be constant to avoid any modification
> > while it is in use.
> >
> > Fixes: c261d1431bd8 ("security: introduce security API and framework")
> > Cc: akhil.go...@nxp.com
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Nelio Laranjeiro <nelio.laranje...@6wind.com>
> > ---
> > lib/librte_security/rte_security.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/librte_security/rte_security.h
> > b/lib/librte_security/rte_security.h
> > index aa3a471a3..679c0a696 100644
> > --- a/lib/librte_security/rte_security.h
> > +++ b/lib/librte_security/rte_security.h
> > @@ -94,7 +94,7 @@ enum rte_security_ipsec_tunnel_type {
> > struct rte_security_ctx {
> > void *device;
> > /**< Crypto/ethernet device attached */
> > - struct rte_security_ops *ops;
> > + const struct rte_security_ops *ops;
> Do we require this change for crypto ops as well.
Yes, only drivers should be able to change modify this pointer.
> > /**< Pointer to security ops for the device */
> > uint16_t sess_cnt;
> > /**< Number of sessions attached to this context */
> >
Thanks,
--
Nélio Laranjeiro
6WIND
