Hi Akhil, > -----Original Message----- > From: Akhil Goyal [mailto:[email protected]] > Sent: Tuesday, October 24, 2017 3:16 PM > To: [email protected] > Cc: Doherty, Declan <[email protected]>; De Lara Guarch, Pablo > <[email protected]>; [email protected]; Nicolau, > Radu <[email protected]>; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; Mcnamara, John > <[email protected]>; Ananyev, Konstantin > <[email protected]>; [email protected]; > [email protected] > Subject: [PATCH v5 01/11] lib/rte_security: add security library >
If you are making a v6, I would change the title to "security: ...". Also, there is an issue described below. Regards, Pablo ... > diff --git a/lib/librte_security/Makefile b/lib/librte_security/Makefile new > file mode 100644 index 0000000..af87bb2 > --- /dev/null > +++ b/lib/librte_security/Makefile ... > + > +# library name > +LIB = librte_security.a > + > +# library version > +LIBABIVER := 1 > + > +# build flags > +CFLAGS += -O3 > +CFLAGS += $(WERROR_FLAGS) There is a compilation issue when the building as shared library, because LDLIBS have not been set. You need to add the following: +LDLIBS += -lrte_eal -lrte_mempool
