On Mon, Oct 23, 2017 at 12:25:45PM -0700, Yongseok Koh wrote:
> On Mon, Oct 23, 2017 at 04:49:56PM +0200, Nelio Laranjeiro wrote:
> > @@ -261,75 +284,59 @@ priv_dev_traffic_enable(struct priv *priv, struct
> > rte_eth_dev *dev)
> > };
> >
> > claim_zero(mlx5_ctrl_flow(dev, &promisc, &promisc));
> > - } else if (dev->data->all_multicast) {
> > + return 0;
> > + }
> > + if (dev->data->all_multicast) {
> > struct rte_flow_item_eth multicast = {
> > .dst.addr_bytes = "\x01\x00\x00\x00\x00\x00",
> > - .src.addr_bytes = "\x01\x00\x00\x00\x00\x00",
> > + .src.addr_bytes = "\x00\x00\x00\x00\x00\x00",
> > .type = 0,
> > };
> >
> > claim_zero(mlx5_ctrl_flow(dev, &multicast, &multicast));
>
> Just curious. No need to consider VLAN for multicast here?
According to the lib documentation no [1]
"Enable the receipt of any multicast frame by an Ethernet device"
> [...]
> These (bcast and ipv6_multi_mask) can be duplicated multiple times if there
> are
> multiple MAC addrs, is that intended?
There is in fact an issue in this series, it does not match my final code.
I'll send a v3.
[1] http://dpdk.org/browse/dpdk/tree/lib/librte_ether/rte_ethdev.h#n2304
--
Nélio Laranjeiro
6WIND
