> -----Original Message----- > From: Shijith Thotton [mailto:shijith.thot...@caviumnetworks.com] > Sent: Monday, October 23, 2017 8:28 PM > To: Yigit, Ferruh <ferruh.yi...@intel.com> > Cc: Wu, Jingjing <jingjing...@intel.com>; Gregory Etelson <greg...@weka.io>; > Harish Patil <harish.pa...@cavium.com>; Thomas Monjalon > <tho...@monjalon.net>; dev@dpdk.org; sta...@dpdk.org; Tan, Jianfeng > <jianfeng....@intel.com>; George Prekas <george.pre...@epfl.ch>; Gonzalez > Monroy, Sergio <sergio.gonzalez.mon...@intel.com> > Subject: Re: [PATCH] igb_uio: remove device reset in open > > On Fri, Oct 20, 2017 at 09:57:38AM -0700, Ferruh Yigit wrote: > > On 10/20/2017 9:55 AM, Ferruh Yigit wrote: > > > Remove device reset during application start, the reset for > > > application exit still there. > > > > > > Reset in open removed because of following comments: > > > 1- Device reset not completed when VF driver loaded, which cause VF PMD > > > initialization error. > > > Adding delay can solve the issue but will increase driver load time. > > > > > > 2- Reset will be issues all devices unconditionally, not very efficient > > > way. > > > > > > Fixes: b58eedfc7dd5 ("igb_uio: issue FLR during open and release of > > > device file") > > > Cc: sta...@dpdk.org > > > > > > Signed-off-by: Ferruh Yigit <ferruh.yi...@intel.com> > > > > Hi Jingjing, Shijith, Gregory, Harish, > > > > Can you please test this on top of current master (which has already > > Jingjin's > > fix) ? > > Hi Ferruh, > > Tested for LiquidIO cards and it works. > > Thanks, > Shijith
Hi, Ferruh For i40e, it's OK too. Thanks Jingjing
