On Mon, Oct 23, 2017 at 09:36:38AM -0700, Ferruh Yigit wrote: > On 10/23/2017 5:28 AM, Shijith Thotton wrote: > > On Fri, Oct 20, 2017 at 09:57:38AM -0700, Ferruh Yigit wrote: > >> On 10/20/2017 9:55 AM, Ferruh Yigit wrote: > >>> Remove device reset during application start, the reset for application > >>> exit still there. > >>> > >>> Reset in open removed because of following comments: > >>> 1- Device reset not completed when VF driver loaded, which cause VF PMD > >>> initialization error. > >>> Adding delay can solve the issue but will increase driver load time. > >>> > >>> 2- Reset will be issues all devices unconditionally, not very efficient > >>> way. > >>> > >>> Fixes: b58eedfc7dd5 ("igb_uio: issue FLR during open and release of > >>> device file") > >>> Cc: sta...@dpdk.org > >>> > >>> Signed-off-by: Ferruh Yigit <ferruh.yi...@intel.com> > >> > >> Hi Jingjing, Shijith, Gregory, Harish, > >> > >> Can you please test this on top of current master (which has already > >> Jingjin's > >> fix) ? > > > > Hi Ferruh, > > > > Tested for LiquidIO cards and it works. > > Thanks Shijith, > > Is following commit needs to be reverted after pci_reset removed from open(): > > Commit: 9ed3f38770c6 ("net/liquidio: remove FLR request to PF driver")
Not required. The commit can stay. Thanks, Shijith