> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Friday, October 13, 2017 11:24 PM > To: Van Haaren, Harry <harry.van.haa...@intel.com> > Cc: dev@dpdk.org; Mcnamara, John <john.mcnam...@intel.com> > Subject: Re: [dpdk-dev] [PATCH] example: add new service cores sample > application > > 14/10/2017 00:20, Thomas Monjalon: > > 25/09/2017 15:23, Harry van Haaren: > > > This commit adds a new sample app, which showcases the value > > > of running services. In particular it allows the application > > > to dynamically schedule services to service-cores. > > > > > > The sample app itself registers a number of dummy services, > > > and applies different profiles to them at runtime. Note that > > > this sample application does not forward any traffic - it > > > demonstrates advanced usage of the service cores API. > > > > > > Signed-off-by: Harry van Haaren <harry.van.haa...@intel.com> > > > --- > > > examples/service_cores/Makefile | 54 +++++++++ > > > examples/service_cores/main.c | 245 > ++++++++++++++++++++++++++++++++++++++++ > > > 2 files changed, 299 insertions(+) > > > > Please add this example in the global examples Makefile. > > And you need to add it also in MAINTAINERS. > > I guess an entry in the doc is maybe required, too?
Yes, yes, and yes. Will all be fixed in v2! -Harry
