> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Monday 16 October 2017 11:04
> To: Mokhtar, Amr <amr.mokh...@intel.com>; dev@dpdk.org
> Cc: Power, Niall <niall.po...@intel.com>; Macnamara, Chris
> <chris.macnam...@intel.com>; Mokhtar, Amr <amr.mokh...@intel.com>
> Subject: RE: [dpdk-dev] [PATCH v1 1/6] bbdev: librte_bbdev library
> 
> 
> 
> > -----Original Message-----
> > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Amr Mokhtar
> > Sent: Saturday, September 30, 2017 2:38 AM
> > To: dev@dpdk.org
> > Cc: Power, Niall <niall.po...@intel.com>; Macnamara, Chris
> > <chris.macnam...@intel.com>; Mokhtar, Amr <amr.mokh...@intel.com>
> > Subject: [dpdk-dev] [PATCH v1 1/6] bbdev: librte_bbdev library
> >
> 
> You are adding a new library here, so I think it deserves a description here 
> (also
> for the other patches).

Wrong command caused the cover letter to go separately. You may find it @ 
http://dpdk.org/ml/archives/dev/2017-September/077027.html
Recovered in v2 patch.

> 
> This is also a good patch to mention the new library in release notes 
> (instead of
> leaving it to the documentation patch).

This was considered in v2 patch. Thanks.

> 
> 
> > Signed-off-by: Amr Mokhtar <amr.mokh...@intel.com>
> 
> ...
> 
> b/lib/librte_bbdev/Makefile
> > new file mode 100644
> > index 0000000..519d49f
> > --- /dev/null
> > +++ b/lib/librte_bbdev/Makefile
> 
> ...
> 
> > +
> > +# versioning export map
> > +EXPORT_MAP := rte_bbdev_version.map
> > +
> > +# library dependencies
> > +DEPDIRS-y += lib/librte_eal lib/librte_mempool lib/librte_kvargs
> 
> Since this patch, DEPDIRS in libraries and drivers are deprecated:
> http://dpdk.org/dev/patchwork/patch/22298/

Done.

> 
> 
> > +
> > +include $(RTE_SDK)/mk/rte.lib.mk

Reply via email to