Hi Ferruh, > -----Original Message----- > From: Yigit, Ferruh > Sent: Saturday, October 7, 2017 7:26 AM > To: Yao, Lei A <lei.a....@intel.com>; Hu, Jiayu <jiayu...@intel.com>; > dev@dpdk.org > Cc: Tan, Jianfeng <jianfeng....@intel.com>; Ananyev, Konstantin > <konstantin.anan...@intel.com>; tho...@monjalon.net; Wu, Jingjing > <jingjing...@intel.com> > Subject: Re: [dpdk-dev] [PATCH v4] app/testpmd: enable the heavyweight > mode TCP/IPv4 GRO > > On 10/7/2017 12:04 AM, Ferruh Yigit wrote: > > On 9/27/2017 8:23 AM, Yao, Lei A wrote: > > <...> > > > >>> The GRO library provides two modes to reassemble packets. Currently, > the > >>> csum forwarding engine has supported to use the lightweight mode to > >>> reassemble TCP/IPv4 packets. This patch introduces the heavyweight > mode > >>> for TCP/IPv4 GRO in the csum forwarding engine. > >>> > >>> With the command "set port <port_id> gro on|off", users can enable > >>> TCP/IPv4 GRO for a given port. With the command "set gro flush > <cycles>", > >>> users can determine when the GROed TCP/IPv4 packets are flushed from > >>> reassembly tables. With the command "show port <port_id> gro", users > can > >>> display GRO configuration. > >>> > >>> The GRO library doesn't re-calculate checksums for merged packets. If > >>> users want the merged packets to have correct IP and TCP checksums, > >>> please select HW IP checksum calculation and HW TCP checksum > calculation > >>> for the port which the merged packets are transmitted to. > >>> > >>> Signed-off-by: Jiayu Hu <jiayu...@intel.com> > >>> Reviewed-by: Ferruh Yigit <ferruh.yi...@intel.com> > > > >> Tested-by: Yao Lei<lei.a....@intel.com> > > > > Applied to dpdk-next-net/master, thanks. > > nope, removing it out back. > > There are "uint8_t port_id" usage a few places, now port_id is uint16_t, > this is new in the repo. > > For testpmd you can prefer "portid_t" storage type as well. > > Can you please send a new version?
No problem. I will send a new version. Thanks, Jiayu
