On Monday 18 September 2017 08:21 PM, Ferruh Yigit wrote:
On 9/9/2017 12:21 PM, Shreyansh Jain wrote:
Signed-off-by: Geoff Thorpe <geoff.tho...@nxp.com>
Signed-off-by: Roy Pledge <roy.ple...@nxp.com>
Signed-off-by: Hemant Agrawal <hemant.agra...@nxp.com>
Signed-off-by: Shreyansh Jain <shreyansh.j...@nxp.com>

<...>

+#if !defined(CONFIG_FSL_QMAN_FQ_LOOKUP) && defined(RTE_ARCH_ARM64)
+#error "_ARM64 requires _FSL_QMAN_FQ_LOOKUP"
+#endif

This PMD enabled with new added config
"defconfig_arm64-armv8a-linuxapp-gcc", which is 64bits. So this means
CONFIG_FSL_QMAN_FQ_LOOKUP always defined for the bus.

Does is make sense to keep above check, but for rest of the code assume
CONFIG_FSL_QMAN_FQ_LOOKUP always set and remove the #ifdefs, to simplify
the code?

<...>


I have removed these lines in v5. They were indeed unnecessary.
Thanks for highlighting.

Reply via email to