On Tuesday 19 September 2017 07:48 PM, Shreyansh Jain wrote:
On Monday 18 September 2017 08:23 PM, Ferruh Yigit wrote:
On 9/9/2017 12:21 PM, Shreyansh Jain wrote:
Signed-off-by: Geoff Thorpe <geoff.tho...@nxp.com>
Signed-off-by: Roy Pledge <roy.ple...@nxp.com>
Signed-off-by: Hemant Agrawal <hemant.agra...@nxp.com>
Signed-off-by: Shreyansh Jain <shreyansh.j...@nxp.com>

<...>
+#ifdef RTE_LIBRTE_DPAA_CHECKING

This is not defined anywhere, it looks this will come from config file
in further patches, config file update can be moved to this patch.

Its more of a debugging macro and it was introduced in later patches.
Not that I see any reason why it can't be introduced here. I will fix this.


+    eqcr->busy = 0;
+    eqcr->pmode = pmode;
+#endif


In the v5, taking cue from yours and Thomas' comments, I have removed a few debugging macros and combined a couple. I have also changed this to "HWDEBUG" and documented this. This macro is necessary for enabling some internally debugging configurations (like error queues).

Reply via email to