On 9/21/2017 9:32 AM, Zhiyong Yang wrote:
> There are two bonding APIs using ABI versioning, and both have
> port_id as parameter. Since we are already breaking ABI, no need
> to keep older versions of APIs.
>
> Signed-off-by: Zhiyong Yang <zhiyong.y...@intel.com>
<...>
> -int
> -rte_eth_bond_8023ad_conf_get_v1708(uint8_t port_id,
> +rte_eth_bond_8023ad_conf_get(uint8_t port_id,
> struct rte_eth_bond_8023ad_conf *conf)
> {
> struct rte_eth_dev *bond_dev;
> @@ -1409,10 +1320,6 @@ rte_eth_bond_8023ad_conf_get_v1708(uint8_t port_id,
> bond_mode_8023ad_conf_get_v1708(bond_dev, conf);
I am aware this is not focus of the patchset, but it would be good to
rename this function too and remove _v1708 suffix.
It seems there is already a function named "bond_mode_8023ad_conf_get"
and after removed code, "bond_mode_8023ad_conf_get" only called by
"bond_mode_8023ad_conf_get_v1708":
bond_mode_8023ad_conf_get_v1708()
bond_mode_8023ad_conf_get()
So it is possible to merge them into name "bond_mode_8023ad_conf_get()"
Thanks,
ferruh
