On 9/9/2017 3:47 PM, Zhiyong Yang wrote: > Modify port_id related code in examples accordingly since port_id > definition in lib and pmd changes. > > Fix some original checkpatch issues and remove some unnecessary > cast at the same time. > > Signed-off-by: Zhiyong Yang <zhiyong.y...@intel.com> > ---
<...> > > diff --git a/doc/guides/rel_notes/release_17_11.rst b/doc/guides/rel_notes/release_17_11.rst > index 170f4f916..98fd7cb23 100644 > --- a/doc/guides/rel_notes/release_17_11.rst > +++ b/doc/guides/rel_notes/release_17_11.rst > @@ -41,6 +41,10 @@ New Features > Also, make sure to start the actual text at the margin. > ========================================================= > > +* **Extended port_id range from uint8_t to uint16_t.** > + > + Extended port_id range from 8 bits to 16 bits in order to support more than > + 256 ports in dpdk. > > Resolved Issues > --------------- There was a LIBABIVER update comment in patch 1/4, let me continue it here. First lets extract documentation on its own patch, instead of being part of "examples" update. And update it a little more: 1- Remove deprecation notice. Each patch implements a deprecation notice also should remove the notice. rel_notes/deprecation.rst should be updated to remove port_id related paragraph. 2- LIBABIVER values of increased libraries should be increased. LIBABIVER is defined in each library Makefile, and set to the value of current version of the library. The libraries breaking ABI/API should increase this by one. So for this patch, following libraries should be updated: drivers/net/bnxt drivers/net/bonding drivers/net/i40e drivers/net/ixgbe lib/librte_ether lib/librte_bitratestats lib/librte_pdump Please double check the list the libraries in case I missed. And it seems we are breaking more API than initially intended. Should we highlight this more? 3- Document updated library versions in release notes in release notes, there is a "Shared Library Versions" section. This section lists all libraries with their versions, like: " librte_ethdev.so.7" [1] This should be updates as: " librte_ethdev.so.8" [1] It seems I have selected wrong sample :(, there is a mismatch in Makefile LIBABIVER value and release notes version for librte_ethdev, I will send a patch for it. <...>
