Re: [dpdk-dev] [PATCH v2 1/4] ethdev: increase port_id range

[Hemant Agrawal]

On 9/4/2017 11:27 AM, Zhiyong Yang wrote:
Extend port_id definition from uint8_t to uint16_t in lib and drivers
data structures, specifically rte_eth_dev_data.
Modify the APIs, drivers and app using port_id at the same time except
some drivers such as MLX4 and MLX5 due to fail to compile them in my
server.
Fix some checkpatch issues from the original code and remove some
unnecessary cast operations.

Signed-off-by: Zhiyong Yang <zhiyong.y...@intel.com>

..<snip>

diff --git a/lib/librte_eventdev/rte_eventdev.h 
b/lib/librte_eventdev/rte_eventdev.h
index 128bc5221..3b52d0f24 100644
--- a/lib/librte_eventdev/rte_eventdev.h
+++ b/lib/librte_eventdev/rte_eventdev.h
@@ -360,7 +360,7 @@ struct rte_event_dev_info {
        /**< Maximum number of event priority levels by this device.
         * Valid when the device has RTE_EVENT_DEV_CAP_EVENT_QOS capability
         */
-       uint8_t max_event_ports;
+       uint16_t max_event_ports;
        /**< Maximum number of event ports supported by this device */

I think, you can leave this one. Or a bit of variable movement will help 
in structure alignment.

if you still want to change, please also change dpaa2_eventdev.h

struct dpaa2_eventdev {
-       uint8_t nb_event_ports;
-       uint8_t resvd_1;
+       uint16_t nb_event_ports;

        uint8_t max_event_port_dequeue_depth;
        /**< Maximum number of events can be dequeued at a time from an
@@ -428,7 +428,7 @@ struct rte_event_dev_config {
         * This value cannot exceed the *max_event_queues* which previously
         * provided in rte_event_dev_info_get()
         */
-       uint8_t nb_event_ports;
+       uint16_t nb_event_ports;
        /**< Number of event ports to configure on this device.
         * This value cannot exceed the *max_event_ports* which previously
         * provided in rte_event_dev_info_get()

..<snip>


diff --git a/lib/librte_eventdev/rte_eventdev_pmd.h 
b/lib/librte_eventdev/rte_eventdev_pmd.h
index 3d72acf3a..ef7c932a7 100644
--- a/lib/librte_eventdev/rte_eventdev_pmd.h
+++ b/lib/librte_eventdev/rte_eventdev_pmd.h
@@ -265,7 +265,7 @@ typedef void (*eventdev_queue_release_t)(struct 
rte_eventdev *dev,
  *
  */
 typedef void (*eventdev_port_default_conf_get_t)(struct rte_eventdev *dev,
-               uint8_t port_id, struct rte_event_port_conf *port_conf);
+               uint16_t port_id, struct rte_event_port_conf *port_conf);

please also update
dpaa2_eventdev_port_def_conf

 /**
  * Setup an event port.
@@ -281,7 +281,7 @@ typedef void (*eventdev_port_default_conf_get_t)(struct 
rte_eventdev *dev,
  *   Returns 0 on success.
  */
 typedef int (*eventdev_port_setup_t)(struct rte_eventdev *dev,
-               uint8_t port_id,
+               uint16_t port_id,
                const struct rte_event_port_conf *port_conf);

please also update
dpaa2_eventdev_port_setup
 /**
@@ -379,7 +379,7 @@ typedef void (*eventdev_dump_t)(struct rte_eventdev *dev, 
FILE *f);
  *   The number of stat values successfully filled into the values array
  */
 typedef int (*eventdev_xstats_get_t)(const struct rte_eventdev *dev,
-               enum rte_event_dev_xstats_mode mode, uint8_t queue_port_id,
+               enum rte_event_dev_xstats_mode mode, uint16_t queue_port_id,
                const unsigned int ids[], uint64_t values[], unsigned int n);

 /**
@@ -407,7 +407,7 @@ typedef int (*eventdev_xstats_reset_t)(struct rte_eventdev 
*dev,
  *   values, and do not fill in any data into xstats_names.
  */
 typedef int (*eventdev_xstats_get_names_t)(const struct rte_eventdev *dev,
-               enum rte_event_dev_xstats_mode mode, uint8_t queue_port_id,
+               enum rte_event_dev_xstats_mode mode, uint16_t queue_port_id,
                struct rte_event_dev_xstats_name *xstats_names,
                unsigned int *ids, unsigned int size);