On Wed, Sep 06, 2017 at 08:53:30AM +0000, Van Haaren, Harry wrote: > > From: Guduri Prathyusha [mailto:gprathyu...@caviumnetworks.com] > > Sent: Wednesday, September 6, 2017 8:16 AM > > To: Van Haaren, Harry <harry.van.haa...@intel.com> > > Cc: dev@dpdk.org; Guduri Prathyusha <gprathyu...@caviumnetworks.com> > > Subject: [dpdk-dev] [PATCH v2] service: fix service lcore stop function > > > > lcore_states store the state of the lcore. Fixing the invalid > > dereference of lcore_states with service number > > > > Unit test case service_lcore_start_stop fails with the above fix. > > Service core was stopped without stopping the service. > > > > This commit fixes the test by adding negative and positive cases of > > stopping the service lcore before and after stopping the service > > respectively > > > > Fixes: 21698354c832 ("service: introduce service cores concept") > > Fixes: f038a81e1c56 ("service: add unit tests") > > > > Signed-off-by: Guduri Prathyusha <gprathyu...@caviumnetworks.com> > > Thanks for fixing and rebase / update to v2. Please mark the v1 of this > patchset as "Superseded" in patchwork. > > Reviewed-by: Harry van Haaren <harry.van.haa...@intel.com> > > > > This patch is based on [1] > > To be totally clear, this patch depends on the service cores (v2) patchset, > as linked at [1]. > >
Thanks. Updated the patchwork status for v1 -Prathyusha > > v2 changes: > > - Combined Patch 1/2 and 2/2 of v1 > > - Rebased to the future service core patches [1] > > > > [1] http://dpdk.org/dev/patchwork/patch/27684/ >
