On Tue, Aug 29, 2017 at 06:08:45AM +0000, Stojaczyk, DariuszX wrote:
Hi Jens,
I'm still not sure I understand the use case. So just for my
understanding: users need to distinct between "the device is going away
temporarily, keep the connection" and "we're shutting down for good", is
that it?
Yes, exactly.
Maybe it's just me or maybe it means you could explain your example in the
commit message a bit more.
Ok. How about the following commit message instead:
```
rte_vhost: added user callbacks for socket open/close
Added new callbacks to notify about socket connection status.
As destroy_device is used for virtqueue processing *pause* as
well as connection close, the user has no distinction between those.
Consider the following scenario:
rte_vhost: received SET_VRING_BASE message,
calling destroy_device() as usual
user: end-user asks to remove the device (together with socket file),
OK, device is not *in use* - that's NOT the behavior we want
calling rte_vhost_driver_unregister() etc.
Instead of changing new_device/destroy_device callbacks and breaking
the ABI, a set of new functions new_connection/destroy_connection
has been added.
```
Sounds good to me. Thanks!
regards,
Jens
