> On Aug 9, 2017, at 7:52 AM, Ferruh Yigit <ferruh.yi...@intel.com> wrote: > > On 8/9/2017 9:42 AM, Zhiyong Yang wrote: >> Extend port_id definition from uint8_t to uint16_t in lib >> ethdev data structures, specifically rte_eth_dev_data and >> modify the APIs using port_id at the same time.
If we have not already decided, we need to apply this patch very soon to hammer out all of the bugs before the next release. >> >> Signed-off-by: Zhiyong Yang <zhiyong.y...@intel.com> >> --- >> app/pdump/main.c | 2 +- >> app/test-pmd/cmdline.c | 4 +- >> app/test-pmd/testpmd.c | 4 +- >> app/test-pmd/testpmd.h | 2 +- > >> drivers/net/bonding/rte_eth_bond.h | 40 ++--- >> drivers/net/bonding/rte_eth_bond_8023ad.c | 6 +- >> drivers/net/bonding/rte_eth_bond_api.c | 54 +++---- >> drivers/net/bonding/rte_eth_bond_pmd.c | 10 +- >> drivers/net/bonding/rte_eth_bond_private.h | 36 ++--- >> drivers/net/failsafe/failsafe_ether.c | 4 +- >> drivers/net/failsafe/failsafe_private.h | 4 +- >> drivers/net/ring/rte_eth_ring.c | 2 +- > > I would expect more drivers would be effected from this, almost all. > > Most PMDs stores the dev->data->port_in in their private data and use > this value while updating mbuf field, those local storage also should be > updated to u16 to prevent data loss. > > Can you please double check drivers, specially data->port_id usages? > I quickly checked null and pcap for example, both needs to be updated. > > Also PMDs with PMD specific API are getting port_id as parameter, so > they should be updated too. > > And I am getting build error for ixgbe and i40e for log type format, - > via clang. > > Thanks, > ferruh > >> lib/librte_ether/rte_ethdev.c | 231 ++++++++++++++-------------- >> lib/librte_ether/rte_ethdev.h | 236 >> ++++++++++++++--------------- >> lib/librte_ether/rte_tm.c | 62 ++++---- >> lib/librte_ether/rte_tm.h | 60 ++++---- >> lib/librte_ether/rte_tm_driver.h | 2 +- >> lib/librte_latencystats/rte_latencystats.c | 8 +- >> lib/librte_pdump/rte_pdump.c | 16 +- >> lib/librte_pdump/rte_pdump.h | 4 +- >> lib/librte_port/rte_port_ethdev.c | 6 +- >> lib/librte_port/rte_port_ethdev.h | 6 +- >> 22 files changed, 404 insertions(+), 395 deletions(-) > > <...> Regards, Keith
