Hi John, On Fri, Aug 04, 2017 at 05:11:18PM +0800, Mcnamara, John wrote: > > -----Original Message----- > > From: Hu, Jiayu > > Sent: Friday, August 4, 2017 9:21 AM > > To: dev@dpdk.org > > Cc: tho...@monjalon.net; Mcnamara, John <john.mcnam...@intel.com>; Hu, > > Jiayu <jiayu...@intel.com> > > Subject: [PATCH v2] doc: add prog_guide for the GRO library > > > > Add prog_guide doc to explain the design of the GRO library. > > > ... > > > +Generic Receive Offload Library > > +=============================== > > + > > ... > > + > > +The GRO library assumes all inputted packets are with correct checksums. > > +In addition, the GRO library doesn't re-calculate checksums for merged > > +packets. If inputted packets are IP fragmented, the GRO library assumes > > +they are complete packets (i.e. with L4 headers). > > It is more correct/common to use input instead of inputted. You should > make this change throughout the doc.
Thanks a lot and I will change them. BRs, Jiayu > > Also this bout be better as: > > The GRO library assumes all input packets have correct checksums. In > addition, the GRO library doesn't re-calculate checksums for merged packets. > > Apart from that: > > Acked-by: John McNamara <john.mcnam...@intel.com>
