On Thu, Jul 27, 2017 at 02:41:46PM -0600, asom...@gmail.com wrote: > From: Alan Somers <asom...@gmail.com> > > "/bin/bash" is a Linuxism. "/usr/bin/env bash" is portable. > > Signed-off-by: Alan Somers <asom...@gmail.com> > --- > examples/performance-thread/l3fwd-thread/test.sh | 2 +- > usertools/dpdk-setup.sh | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/examples/performance-thread/l3fwd-thread/test.sh > b/examples/performance-thread/l3fwd-thread/test.sh > index b7718b622..eb1fe2dc2 100755 > --- a/examples/performance-thread/l3fwd-thread/test.sh > +++ b/examples/performance-thread/l3fwd-thread/test.sh > @@ -1,4 +1,4 @@ > -#!/bin/bash > +#!/usr/bin/env bash > > case "$1" in > This script doesn't look to be using any bash specific features to me, so a better fix might be to change it to use /bin/sh rather than requiring bash itself. [Needs testing, to check there isn't something bash-specific hidden away, obviously]
> diff --git a/usertools/dpdk-setup.sh b/usertools/dpdk-setup.sh > index c4fec5a63..ebf36f830 100755 > --- a/usertools/dpdk-setup.sh > +++ b/usertools/dpdk-setup.sh > @@ -1,4 +1,4 @@ > -#! /bin/bash > +#! /usr/bin/env bash > > # BSD LICENSE > # > -- Not sure having this linux-specific is a problem for dpdk-setup.sh, since I don't think large parts of that script work with BSD anyway, e.g. it assumes a linux hugetlbfs filesystem for hugepage setup. Not that there is any harm in making the change you suggest either. /Bruce
