On Mon, Jul 31, 2017 at 09:11:11AM -0600, alan somers wrote: > On Fri, Jul 28, 2017 at 3:28 AM, Bruce Richardson > <bruce.richard...@intel.com> wrote: > > On Thu, Jul 27, 2017 at 02:41:46PM -0600, asom...@gmail.com wrote: > >> From: Alan Somers <asom...@gmail.com> > >> > >> "/bin/bash" is a Linuxism. "/usr/bin/env bash" is portable. > >> > >> Signed-off-by: Alan Somers <asom...@gmail.com> > >> --- > >> examples/performance-thread/l3fwd-thread/test.sh | 2 +- > >> usertools/dpdk-setup.sh | 2 +- > >> 2 files changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/examples/performance-thread/l3fwd-thread/test.sh > >> b/examples/performance-thread/l3fwd-thread/test.sh > >> index b7718b622..eb1fe2dc2 100755 > >> --- a/examples/performance-thread/l3fwd-thread/test.sh > >> +++ b/examples/performance-thread/l3fwd-thread/test.sh > >> @@ -1,4 +1,4 @@ > >> -#!/bin/bash > >> +#!/usr/bin/env bash > >> > >> case "$1" in > >> > > This script doesn't look to be using any bash specific features to me, > > so a better fix might be to change it to use /bin/sh rather than > > requiring bash itself. [Needs testing, to check there isn't something > > bash-specific hidden away, obviously] > > True. Unfortunately, I can't test it right now because I can't get > DPDK to build on either Linux or FreeBSD, and I'm out of time to debug > the build failures for now. Would you like me to resubmit the patch, > altered to use /bin/sh, without testing? > > > I'm not sure it's that important a change that we need to rush into doing so.
What difficulties are you having getting DPDK to build? Is it just platform setup issues? /Bruce
