> -----Original Message-----
> From: Yuanhan Liu [mailto:y...@fridaylinux.org]
> Sent: Friday, July 7, 2017 2:02 PM
> To: dev@dpdk.org
> Cc: Wu, Jingjing <jingjing...@intel.com>; Yuanhan Liu <y...@fridaylinux.org>
> Subject: [PATCH 2/2] testpmd: give more hint on invalid RETA size
>
> Print the valid RTE size range so that user knows what goes wrong.
>
> Signed-off-by: Yuanhan Liu <y...@fridaylinux.org>
> ---
> app/test-pmd/cmdline.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> index c8faef9..d32a1df 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -2140,12 +2140,14 @@ cmd_showport_reta_parsed(void *parsed_result,
> struct cmd_showport_reta *res = parsed_result;
> struct rte_eth_rss_reta_entry64 reta_conf[8];
> struct rte_eth_dev_info dev_info;
> + uint16_t max_reta_size;
>
> memset(&dev_info, 0, sizeof(dev_info));
> rte_eth_dev_info_get(res->port_id, &dev_info);
> - if (dev_info.reta_size == 0 || res->size > dev_info.reta_size ||
> - res->size > ETH_RSS_RETA_SIZE_512) {
> - printf("Invalid redirection table size: %u\n", res->size);
> + max_reta_size = RTE_MIN(dev_info.reta_size, ETH_RSS_RETA_SIZE_512);
> + if (res->size == 0 || res->size > max_reta_size) {
> + printf("Invalid redirection table size: %u (1-%u)\n",
> + res->size, max_reta_size);
> return;
> }
>
Why not merge this with previous one?
Thanks
Jingjing
