> -----Original Message----- > From: akhil.go...@nxp.com [mailto:akhil.go...@nxp.com] > Sent: Thursday, June 29, 2017 9:49 PM > To: dev@dpdk.org > Cc: hemant.agra...@nxp.com; De Lara Guarch, Pablo > <pablo.de.lara.gua...@intel.com>; Doherty, Declan > <declan.dohe...@intel.com>; Akhil Goyal <akhil.go...@nxp.com> > Subject: [PATCH 0/5] crypto/dpaa2_sec optimization and feature update > > From: Akhil Goyal <akhil.go...@nxp.com> > > This patchset updates dpaa2_sec crypto driver with following: > - optimization in data path for memory allocation > - add support for additional AES algorithms like AES-GCM and AES-CTR > - Update test cases in test_cryptodev for all the supported test cases. > - Update documentation for supported algorithms > > The patches are based on dpdk-crypto-next and are rebased over the latest > crypto restructuring changes by Pablo. > http://dpdk.org/ml/archives/dev/2017-June/069372.html > > > Akhil Goyal (5): > crypto/dpaa2_sec: add per device mempool to store frame list entries > crypto/dpaa2_sec: add descriptor support for gcm and ctr > crypto/dpaa2_sec: add support for AES-GCM and CTR > test/test: add test cases for gcm and ctr in dpaa2_sec test suite > doc: update documentation for dpaa2_sec supported algos > > doc/guides/cryptodevs/dpaa2_sec.rst | 9 +- > doc/guides/cryptodevs/features/dpaa2_sec.ini | 6 + > drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 7 + > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 384 > ++++++++++++++++++++++++--- > drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 100 ++++--- > drivers/crypto/dpaa2_sec/hw/desc/algo.h | 226 +++++++++++++++- > drivers/crypto/dpaa2_sec/hw/desc/ipsec.h | 19 +- > test/test/test_cryptodev.c | 94 ++++++- > test/test/test_cryptodev_aes_test_vectors.h | 78 ++++-- > test/test/test_cryptodev_blockcipher.c | 1 + > test/test/test_cryptodev_des_test_vectors.h | 24 +- > test/test/test_cryptodev_hash_test_vectors.h | 36 ++- > 12 files changed, 846 insertions(+), 138 deletions(-) > > -- > 2.9.3
Hi Akhil, There are some issues with check-git-log.sh on your patches. Wrong headline format: test/test: add test cases for gcm and ctr in dpaa2_sec test suite Wrong headline prefix: crypto/dpaa2_sec: add per device mempool to store frame list entries Wrong headline lowercase: crypto/dpaa2_sec: add hw desc support for CTR crypto/dpaa2_sec: add hw desc support for AES-GCM Headline too long: crypto/dpaa2_sec: add per device mempool to store frame list entries test/test: add test cases for gcm and ctr in dpaa2_sec test suite For the first patch, change from "test/test: ...." to "test/crypto..." too. Also, you can probably merge the last two patches, as you are adding existing tests to the dpaa2 testsuite, for the changes made in patch 4. Lastly, I submitted a v4 for the crypto rework, so make sure you rebase on top of this patchset before sending a v2. Thanks! Pablo