On 06/29/2017 09:21 AM, Maxime Coquelin wrote:
On 06/29/2017 08:07 AM, Ivan Dyukov wrote:
On 06/28/2017 03:54 PM, Maxime Coquelin wrote:
On 06/28/2017 02:40 PM, Ivan Dyukov wrote:
To compare enabled features in current device we must use bit
mask instead of bit position.
CC: sta...@dpdk.org
Fixes: c843af3aa13e ("vhost: access header only")
Signed-off-by: Ivan Dyukov <i.dyu...@samsung.com>
---
lib/librte_vhost/virtio_net.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
Thanks for the fix Ivan, and sorry for introducing this bug.
Out of curiosity, did you noticed it because it broke offloading,
or just by code review?
I didn't see any breakages. It's just code review.
Ok, thanks.
FYI, I just found another case in vhost.c, sending patch soon.
Cheers,
Maxime
