> > > > Should it block the app startup if isolated-mode setting fails? > > > > > > if isolated mode cannot be enabled on any port, that port cannot be > > > initialized and that causes testpmd to quit, at least it won't go > > > against the user's wishes > > > > If so, I prefer the isolated_mode to be port's argument but not global one. > > How about to add a command to configure the isolate mode? > > There is already a command to configure isolate mode per-port: > http://dpdk.org/patch/25320 > http://dpdk.org/doc/guides/testpmd_app_ug/testpmd_funcs.html#flow > -syntax > > I think it does not make sense to replicate this per-port command in command > line parameters. > All the other parameters are global: > http://dpdk.org/doc/guides/testpmd_app_ug/run_app.html#testpmd- > command-line-options > The idea here is to have a global isolate mode with a general option.
OK. Thanks Then I'm fine with it.