> -----Original Message----- > From: Vasily Philipov [mailto:vasi...@mellanox.com] > Sent: Wednesday, June 21, 2017 5:44 PM > To: Wu, Jingjing <jingjing...@intel.com>; dev@dpdk.org > Cc: Adrien Mazarguil <adrien.mazarg...@6wind.com>; Nélio Laranjeiro > <nelio.laranje...@6wind.com> > Subject: RE: [dpdk-dev] [PATCH v4 4/4] app/testpmd: add isolated mode > parameter > > > > > -----Original Message----- > > From: Wu, Jingjing [mailto:jingjing...@intel.com] > > Sent: Tuesday, June 20, 2017 04:27 > > To: Vasily Philipov <vasi...@mellanox.com>; dev@dpdk.org > > Cc: Adrien Mazarguil <adrien.mazarg...@6wind.com>; Nélio Laranjeiro > > <nelio.laranje...@6wind.com> > > Subject: RE: [dpdk-dev] [PATCH v4 4/4] app/testpmd: add isolated mode > > parameter > > > > > > > +/* > > > * Avoids to check link status when starting/stopping a port. > > > */ > > > uint8_t no_link_check = 0; /* check by default */ @@ -1422,6 > > > +1427,15 @@ static void eth_event_callback(uint8_t port_id, > > > if (port->need_reconfig > 0) { > > > port->need_reconfig = 0; > > > > > > + if (isolated_mode) { > > > + int ret = port_flow_isolate(pi, 1); > > > + if (ret) { > > > + printf("Failed to apply isolated" > > > + " mode on port %d\n", pi); > > > + return -1; > > > + } > > > + } > > > + > > Should it block the app startup if isolated-mode setting fails? > > if isolated mode cannot be enabled on any port, that port cannot be > initialized > and that causes testpmd to quit, at least it won't go against the user's > wishes
If so, I prefer the isolated_mode to be port's argument but not global one. How about to add a command to configure the isolate mode?
