On Fri, 26 May 2017 09:17:33 +0300
Gregory Etelson <greg...@weka.io> wrote:
> Thank you.
>
> Regards,
> Gregory
>
> On Friday, 26 May 2017 09:05:11 IDT Shijith Thotton wrote:
> > On Fri, May 26, 2017 at 07:30:58AM +0300, Gregory Etelson wrote:
> >
> > Hi Gregory,
> >
> > The patch is useful for LiquidIO PMD as we can avoid VF FLR request to
> > PF. One comment inline..
> >
> > [..]
> > > > >
> > > > > +static int
> > > > > +igbuio_pci_release(struct uio_info *info, struct inode *inode)
> > > > > +{
> > > > > + int ret;
> > > > > + struct rte_uio_pci_dev *udev = info->priv;
> > > > > + struct pci_dev *dev = udev->pdev;
> > > > > + ret = __pci_reset_function(dev);
> >
> > s/__pci_reset_function/pci_reset_function
> >
> > > > > + dev_info(&dev->dev, "pci_reset_function %s \n",
> > > > > + ret == 0 ? "succeded" : "failed");
> > > > > + return 0;
> > > > > +}
> > [..]
> >
> > Thanks,
> > Shijith
> >
>
What does VFIO do?
It looks like in vfio case pci_enable is held off until open and pci_disable is
done
on close. There are other things that may need to be done to make close work
correctly. Like turning of msix. Also reset may not always be possible.
