Hello,
This patch introduces idea I would like to implement in igb_uio driver
However, I would like to get hardware experts confirmation.
If the procedure correct I'll submit proper patch
Regards,
Gregory
On Thursday, 25 May 2017 21:42:42 IDT Stephen Hemminger wrote:
> On Wed, 24 May 2017 14:22:11 +0300
> Gregory Etelson <greg...@weka.io> wrote:
>
> >
> > +static int
> > +igbuio_pci_release(struct uio_info *info, struct inode *inode)
> > +{
> > + int ret;
> > + struct rte_uio_pci_dev *udev = info->priv;
> > + struct pci_dev *dev = udev->pdev;
> > + ret = __pci_reset_function(dev);
> > + dev_info(&dev->dev, "pci_reset_function %s \n",
> > + ret == 0 ? "succeded" : "failed");
> > + return 0;
> > +}
> > +
> > +
>
> Patch in general looks ok, but:
> * no Signed-off
> * whitespace issues
> * doesn't pass kernel coding style
> * don't log on success, why log at all??
>
