On 22/05/2017 13:36, Ferruh Yigit wrote:
On 5/22/2017 1:07 PM, Andrew Rybchenko wrote:
On 05/22/2017 02:29 PM, Ferruh Yigit wrote:
On 5/18/2017 3:00 PM, Andrew Rybchenko wrote:
Signed-off-by: Andrew Rybchenko <arybche...@solarflare.com>
Reviewed-by: Andy Moreton <amore...@solarflare.com>
<...>

  Linux VFIO           = Y
diff --git a/drivers/net/sfc/sfc.h b/drivers/net/sfc/sfc.h
index 772a713..007ed24 100644
--- a/drivers/net/sfc/sfc.h
+++ b/drivers/net/sfc/sfc.h
@@ -225,7 +225,18 @@ struct sfc_adapter {
        uint8_t                         rss_key[SFC_RSS_KEY_SIZE];
  #endif
+ /*
+        * Shared memory copy of the Rx datapath name to be used by
+        * the secondary process to find Rx datapath to be used.
+        */
+       char                            *dp_rx_name;
Why not use sa->dp_rx->dp.name to find the dp_rx? That variable should
be shared between processes already?
sa->dp_rx is a pointer to .data section (sfc_efx_rx or sfc_ef10_rx)
which is (may be) different in primary and secondary processes.
OK, thanks.
Does it make sense to implement strdup as rte_strdup, so others can
re-use it? @sergio, what do you think?

IMHO I would hold until there are more cases using it.

Sergio

Reply via email to