>
> Right, i prefer the following though, what do you think?
>
> for (i = 0; i < RTE_MAX_LCORE; i++) {
> sock_num = rte_lcore_to_socket_id(i);
> if (new_socket_id(sock_num)) {
> if (num_sockets >= RTE_MAX_NUMA_NODES) {
> rte_exit(EXIT_FAILURE,
> "Total sockets greater than %u\n",
> RTE_MAX_NUMA_NODES);
> }
> socket_ids[num_sockets++] = sock_num;
> }
>
That looks good :)
> > One more thing, if this patch is fixing a bug, I think "fix" should be
> > added in title.
>
> OK, I guess I can change the commit title and message.
>
> BTW note that there is a V3 with Thomas requested changes.
> If we agree on above I can submit a v4 with the last updates.
>
>
OK.
Thanks
Jingjing
