28/04/2017 10:30, Wu, Jingjing: > From: Pei, Yulong > > > > Previous numa_support = 0 by default, it need to add --numa to testpmd > > command line to enable numa, so port_numa and ring_numa were initialized at > > function launch_args_parse(), now testpmd change numa_support = 1 as > > default, > > so port_numa and ring_numa also need to initialize by default, otherwise > > port- > > >socket_id will be probed to wrong value. > > > > Fixes: 999b2ee0fe45 ("app/testpmd: enable NUMA support by default") > > > > Signed-off-by: Yulong Pei <yulong....@intel.com> > > You forgot "fix" in title if the patch is fixing a problem. > Anyway, the change is OK. > Acked-by: Jingjing Wu <jingjing...@intel.com>
Please rebase on top of http://dpdk.org/commit/3ab64341d and check if the patch needs to be reworked. The check of port_numa array below is weird. PS: please use --in-reply-to for v5.