Re: [dpdk-dev] [PATCH 2/2] net/ixgbe: fix a error type check for flow type

[Zhao1, Wei]

Hi， Wenzhuo

> -----Original Message-----
> From: Lu, Wenzhuo
> Sent: Friday, April 21, 2017 10:49 AM
> To: Zhao1, Wei <wei.zh...@intel.com>; dev@dpdk.org
> Cc: Zhao1, Wei <wei.zh...@intel.com>
> Subject: RE: [dpdk-dev] [PATCH 2/2] net/ixgbe: fix a error type check for flow
> type
> 
> Hi Wei,
> 
> > -----Original Message-----
> > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wei Zhao
> > Sent: Thursday, April 20, 2017 11:28 AM
> > To: dev@dpdk.org
> > Cc: Zhao1, Wei
> > Subject: [dpdk-dev] [PATCH 2/2] net/ixgbe: fix a error type check for
> > flow type
> >
> > The type check for flow_type should be IXGBE_ATR_FLOW_TYPE_IPV4 in
> > special card not RTE_ETH_FLOW_NONFRAG_IPV4_OTHER.
> >
> > Fixes: dc0c16105d2 ("ixgbe: fix X550 flow director check")
> >
> > Signed-off-by: Wei Zhao <wei.zh...@intel.com>
> > ---
> >  drivers/net/ixgbe/ixgbe_fdir.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ixgbe/ixgbe_fdir.c
> > b/drivers/net/ixgbe/ixgbe_fdir.c index 3b9d60c..6f19b91 100644
> > --- a/drivers/net/ixgbe/ixgbe_fdir.c
> > +++ b/drivers/net/ixgbe/ixgbe_fdir.c
> > @@ -1241,7 +1241,7 @@ ixgbe_fdir_filter_program(struct rte_eth_dev
> *dev,
> >          hw->mac.type == ixgbe_mac_X550EM_x ||
> >          hw->mac.type == ixgbe_mac_X550EM_a) &&
> >         (rule->ixgbe_fdir.formatted.flow_type ==
> > -        RTE_ETH_FLOW_NONFRAG_IPV4_OTHER) &&
> > +        IXGBE_ATR_FLOW_TYPE_IPV4) &&
> >         (info->mask.src_port_mask != 0 ||
> >          info->mask.dst_port_mask != 0)) {
> >             PMD_DRV_LOG(ERR, "By this device,"
> > --
> > 2.9.3
> It’s a good fix. But please change the comments and error log accordingly.

I will commit a new v2 for this patch as your suggestion.