On Thu, Apr 20, 2017 at 11:49:33AM -0700, John Daley wrote:
> Change comments for rte_flow_validate() function to indicate that flow
> rule collision and resource validation is optional for PMDs and
> therefore the return codes may have different meanings.
>
> Fixes: b1a4b4cbc0a8 ("ethdev: introduce generic flow API")
>
> Signed-off-by: John Daley <johnd...@cisco.com>
One last nit below (not sure if you need to send a new version). In any
case:
Acked-by: Adrien Mazarguil <adrien.mazarg...@6wind.com>
[...]
> @@ -1360,8 +1362,13 @@ Return values:
> - ``-EINVAL``: unknown or invalid rule specification.
> - ``-ENOTSUP``: valid but unsupported rule specification (e.g. partial
> bit-masks are unsupported).
> -- ``-EEXIST``: collision with an existing rule.
> -- ``-ENOMEM``: not enough resources.
> +- ``EEXIST``: collision with an existing rule. Only returned if device
> + supports flow rule collision checking and there was a flow rule
> + collision. Not receiving this return code is no guarantee that creating
> + the rule will not fail due to a collision.
> +- ``ENOMEM``: not enough memory to execute the function, or if the device
> + supports resource validation, resource limitation on the device.
> +
This new empty line should be removed.
> - ``-EBUSY``: action cannot be performed due to busy device resources, may
> succeed if the affected queues or even the entire port are in a stopped
> state (see ``rte_eth_dev_rx_queue_stop()`` and ``rte_eth_dev_stop()``).
[...]
Thanks.
--
Adrien Mazarguil
6WIND
