> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Monday, March 27, 2017 12:21 PM > To: Van Haaren, Harry <harry.van.haa...@intel.com> > Cc: dev@dpdk.org; Richardson, Bruce <bruce.richard...@intel.com> > Subject: Re: [PATCH v5 08/20] event/sw: add support for linking queues to > ports
<snip non-SINGLE_LINK related feedback> > > + break; > > + > > + if (q->type == SW_SCHED_TYPE_DIRECT) { > > + /* check directed qids only map to one port */ > > + if (p->num_qids_mapped > 0) { > > + rte_errno = -EDQUOT; > > + break; > > + } > > + /* check port only takes a directed flow */ > > + if (num > 1) { > > + rte_errno = -EDQUOT; > > + break; > > + } > > + > > + p->is_directed = 1; > > + p->num_qids_mapped = 1; > > + } else if (q->type == RTE_SCHED_TYPE_ORDERED) { > > Will this "else if" have similar issue shared in > http://dpdk.org/ml/archives/dev/2017-March/061497.html This particular issue has been resolved by fixing in patch 06/20. The other issues you've raised on this patch are fixed, Thanks again for your feedback - the bug in 06/20 was a great catch!