> -----Original Message----- > From: Wu, Jingjing > Sent: Wednesday, March 22, 2017 7:53 PM > To: Guo, Jia <jia....@intel.com>; Zhang, Helin <helin.zh...@intel.com> > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [dpdk-dev v2 1/3] examples: enable HW CRC strip by default > > > > > -----Original Message----- > > From: Guo, Jia > > Sent: Monday, March 20, 2017 5:58 PM > > To: Zhang, Helin <helin.zh...@intel.com>; Wu, Jingjing > > <jingjing...@intel.com> > > Cc: dev@dpdk.org; Guo, Jia <jia....@intel.com>; sta...@dpdk.org > > Subject: [dpdk-dev v2 1/3] examples: enable HW CRC strip by default > > > > Since VF has no ability to disable/enable HW CRC strip for non-DPDK PF > > drivers, and for most case of kernel driver default enable HW CRC > > strip, if disable HW CRC strip in example app's rxmode, VF driver will > > return fail and result the VF launch failure. So this patch default to > > enable HW CRC strip to let VF launch successful. > > > > Signed-off-by: Jeff Guo <jia....@intel.com> > > Cc: sta...@dpdk.org > > > Series Acked-by Jingjing Wu <jingjing...@intel.com>
Have minor comments on patch [2/3] and [3/3], so the ACK is not for the series, just for this patch.