On 3/6/2017 5:25 PM, Shrikrishna Khare wrote: > > > On Fri, 3 Mar 2017, Ferruh Yigit wrote: > >>> Shrikrishna Khare (7): >>> vmxnet3: prepare for version 3 changes >>> vmxnet3: introduce generalized command interface to configure the >>> device >>> vmxnet3: allow variable length transmit data ring buffer >>> vmxnet3: add receive data ring support >>> vmxnet3: add reserved version 3 command >>> vmxnet3: introduce command to register memory region >>> vmxnet3: update to version 3 >> >> Hi Shrikrishna, >> >> Can you please update release notes with this change with one or two >> sentences in next version of the patchset? >> >> Also there are helper scripts in dpdk: >> - dpdk/devtools/check-git-log.sh to check patch titles >> - dpdk/devtools/checkpatches.sh (a wrapper to Linux checkpatch.pl) >> >> Both are generating some warnings, can you please check them? >> >> For checkpatches script, it is free to ignore CAMELCASE & >> LONG_LINE_STRING warnings. > > Hi Ferruh, > > Thank you for the review comments. I have addressed them all and sent v2 > patches for review. > > In addition to CAMELCASE, there are few LEADING_SPACE warnings that I > have not addressed. This is an existing problem with all the vmxnet3 > headers and only fixing it for the lines added by this patch series will > be odd. Hope that is OK.
I agree, better to keep existing style. > Perhaps a separate patch can fix these style > issues in vmxnet3 header files all at once. That would be nice, thank you. > > Thanks, > Shri <...>
