On 3/3/2017 8:54 AM, Pascal Mazon wrote:
> The call to rte_eth_dev_allocate(tap_name) sets dev->data->name to
> tap_name (e.g. "dtap0").
>
> A look-up using tap_name is expected to return this device, not a
> look-up using name (e.g. "net_tap0").
This will break rte_pmd_tap_remove(), because it gets device name
(net_tap0) as parameter.
And logically this is wrong too, current eth_dev->data->name is to keep
device name, all other PMDs use this way, not for Linux interface name.
Current tap PMD, first gives "dtap0" to rte_eth_dev_allocate() as
argument, which sets device name to this value. Later with snprintf()
overwrites the device name with correct value, I think better thing to
do is give correct argument to rte_eth_dev_allocate() and remove snprintf()
>
> Signed-off-by: Pascal Mazon <pascal.ma...@6wind.com>
> ---
> drivers/net/tap/rte_eth_tap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
> index 47a706070652..14c345f07afa 100644
> --- a/drivers/net/tap/rte_eth_tap.c
> +++ b/drivers/net/tap/rte_eth_tap.c
> @@ -691,7 +691,7 @@ eth_dev_tap_create(const char *name, char *tap_name)
> dev->driver = NULL;
> dev->rx_pkt_burst = pmd_rx_burst;
> dev->tx_pkt_burst = pmd_tx_burst;
> - snprintf(dev->data->name, sizeof(dev->data->name), "%s", name);
> + snprintf(dev->data->name, sizeof(dev->data->name), "%s", tap_name);
>
> /* Presetup the fds to -1 as being not valid */
> for (i = 0; i < RTE_PMD_TAP_MAX_QUEUES; i++) {
>
