On 2/13/2017 10:09 AM, Yang, Qiming wrote:
> Hi, Ferruh
>
>> -----Original Message-----
>> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yang, Qiming
>> Sent: Friday, February 10, 2017 7:21 PM
>> To: Yigit, Ferruh <ferruh.yi...@intel.com>; dev@dpdk.org
>> Cc: Wu, Jingjing <jingjing...@intel.com>
>> Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix vlan insert code redundance
>>
>>> On 2/10/2017 1:26 AM, Qiming Yang wrote:
>>>> This patch removed useless tx_flags in vlan insertion.
>>>
>>> Overall this looks good, I wonder what was the initial intention of
>>> this code, understanding it helps to figure out if there is a hidden defect.
>>
>> Thank you for your remind. I'll investigate it.
>
> I have aligned with Helin (he contribute these code), and make sure these
> code is useless, these code is left by history.
>
>>
>>>
>>> This code not fixes a defect, but improves the code, is there any
>>> performance gain with this?
>>
>> I'll do more test and give you a feedback.
>
> According to my test, this code will not bring any obvious performance gain,
> and no lose also.
> And as you said this is not a bug fix, should I remove the fix line and
> modify the commit log?
Please do if you will send a new version already, no need to send a new
version just for title update.
Thanks,
ferruh
>
>>
>>> If not, I am for deferring this to next release.
>>>
>>>>
>>>> Fixes: 4861cde46116 ("i40e: new poll mode driver")
>>>>
>>>> Signed-off-by: Qiming Yang <qiming.y...@intel.com>
>>>> ---
>
