On 12/9/2016 11:27 AM, Bernard Iremonger wrote:
> Use the the following ixgbe public functions:
> 
> rte_pmd_ixgbe_set_vf_rate_limit
> rte_pmd_ixgbe_set_vf_rx
> rte_pmd_ixgbe_set_vf_rxmode
> rte_pmd_ixgbe_set_vf_tx
> rte_pmd_ixgbe_set_vf_vlan_filter
> 
> Signed-off-by: Bernard Iremonger <bernard.iremon...@intel.com>

<...>

> @@ -2388,23 +2391,11 @@ int
>  set_vf_rate_limit(portid_t port_id, uint16_t vf, uint16_t rate, uint64_t 
> q_msk)
>  {
>       int diag;
> -     struct rte_eth_link link;
> -
> -     if (q_msk == 0)
> -             return 0;
>  
> -     if (port_id_is_invalid(port_id, ENABLED_WARN))
> -             return 1;
> -     rte_eth_link_get_nowait(port_id, &link);
> -     if (rate > link.link_speed) {
> -             printf("Invalid rate value:%u bigger than link speed: %u\n",
> -                     rate, link.link_speed);
> -             return 1;
> -     }

Why these changes required? Isn't only change is location and naming of
the ...set_vf_rate_limit() ?

> -     diag = rte_eth_set_vf_rate_limit(port_id, vf, rate, q_msk);
> +     diag = rte_pmd_ixgbe_set_vf_rate_limit(port_id, vf, rate, q_msk);
>       if (diag == 0)
>               return diag;
> -     printf("rte_eth_set_vf_rate_limit for port_id=%d failed diag=%d\n",
> +     printf("rte_pmd_ixgbe_set_vf_rate_limit for port_id=%d failed 
> diag=%d\n",
>               port_id, diag);
>       return diag;
>  }
> 

Reply via email to