On 12/9/2016 11:27 AM, Bernard Iremonger wrote: > This patchset implements the following deprecation notice: > [PATCH v1] doc: announce API and ABI change for librte_ether > > The following functions from eth_dev_ops have been moved to the ixgbe PMD > and renamed: > > ixgbe_set_pool_rx_mode > ixgbe_set_pool_rx > ixgbe_set_pool_tx > ixgbe_set_pool_vlan_filter > ixgbe_set_vf_rate_limit > > Renamed the functions to the following: > > rte_pmd_ixgbe_set_vf_rxmode > rte_pmd_ixgbe_set_vf_rx > rte_pmd_ixgbe_set_vf_tx > rte_pmd_ixgbe_set_vf_vlan_filter > rte_pmd_ixgbe_set_vf_rate_limit > > Testpmd has been modified to use the following functions: > rte_pmd_ixgbe_set_vf_rxmode > rte_pmd_ixgbe_set_vf_rate_limit > > New testpmd commands have been added to test the following functions: > rte_pmd_ixgbe_set_vf_rx > rte_pmd_ixgbe_set_vf_tx > rte_pmd_ixgbe_set_vf_vlan_filter > > The testpmd user guide has been updated for the new commands. > > Bernard Iremonger (5): > net/ixgbe: move set VF functions from the ethdev > app/testpmd: use ixgbe public functions > app/testpmd: add command for set VF VLAN filter > app/testpmd: add command for set VF receive > app/testpmd: add command for set VF transmit > > app/test-pmd/cmdline.c | 270 > +++++++++++++++++++++++++++- > app/test-pmd/config.c | 31 ++-- > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 21 +++ > drivers/net/ixgbe/ixgbe_ethdev.c | 263 +++++++++++++++++++++++++++ > drivers/net/ixgbe/rte_pmd_ixgbe.h | 104 +++++++++++ > drivers/net/ixgbe/rte_pmd_ixgbe_version.map | 10 ++ > 6 files changed, 678 insertions(+), 21 deletions(-) >
Why this patchset doesn't remove ethdev updates for these functions? ixgbe is the only user for these eth-dev_ops, since code moved to ixgbe driver, they and relevant rte_eth_xx functions (and deprecation notice) can be removed in this patchset. Most probably after testpmd updated to prevent compilation errors.
