On 18/09/16 09:16, Yuanhan Liu wrote: > On Wed, Sep 14, 2016 at 04:32:46PM +0100, John Griffin wrote: >> Hi Liu, >> Comments embedded. >> >> Rgds, >> John. >> >> On 05/09/16 04:23, Yuanhan Liu wrote: >>> On Thu, Sep 01, 2016 at 11:21:38AM +0100, John Griffin wrote: >>>> Remove the dependency on dev->driver->pci_drv.name when >>>> creating the memzone for the qat hardware queues. >>>> The pci_drv.name may grow too large for RTE_MEMZONE_NAMESIZE. >>> >>> Will the "may grow too large" cause any issues? If so, state it here. If >>> not, marking this patch as a "fix" patch doesn't make sense to me then. >> We discovered this when applying a future patch (2141c21966) and it exposed >> this issue. >> Problem is we create a memzone per hardware queue pair and if the memzone >> name is too large, then this code will not produce a unique >> name and two qps will end using the same memzone. > > Thanks for the info, and I think you should put it in the commit log: it > helps people to really know what might go wrong without this fix. > > --yliu > No problem. Yes will add to the v2.
Rgds, John.
