I will refine the commit log. Other hand, since the issue is not directly related with prior patch, it just because some nic type adding request some special behavior handle. So it is reported issue fix, but may be have not corresponding fix line. Thanks jingjing's review.
Best regards, Jeff Guo -----Original Message----- From: Wu, Jingjing Sent: Monday, October 24, 2016 5:10 PM To: Guo, Jia <jia.guo at intel.com>; Zhang, Helin <helin.zhang at intel.com> Cc: dev at dpdk.org; Yigit, Ferruh <ferruh.yigit at intel.com> Subject: RE: [PATCH] net/i40e: fix the hash filter invalid calculation in X722 > -----Original Message----- > From: Guo, Jia > Sent: Thursday, October 20, 2016 10:49 AM > To: Zhang, Helin <helin.zhang at intel.com>; Wu, Jingjing > <jingjing.wu at intel.com> > Cc: dev at dpdk.org; Guo, Jia <jia.guo at intel.com>; Yigit, Ferruh > <ferruh.yigit at intel.com> > Subject: [PATCH] net/i40e: fix the hash filter invalid calculation in > X722 > > As X722 extracts IPv4 header to Field Vector different with > XL710/X710, need to corresponding to modify the fields of IPv4 header > in input set to map different default Field Vector Table of different NICs. > Signed-off-by: Jeff Guo <jia.guo at intel.com> > --- > v3: > remove the x722 macro > v2: > fix compile error when x722 macro is not defined and simplify the code > to avoid duplication. > --- > drivers/net/i40e/i40e_ethdev.c | 60 > +++++++++++++++++++++++++++++++++--------- > 1 file changed, 47 insertions(+), 13 deletions(-) > How about change the commit log it like: When verifying the Hash filtering on X722, we found the behavior was not expected. For example, the hash value in descriptor is incorrect. That was because X722 uses different way of hash key word selection comparing with X710/XL710. This patch fixes it by setting X722 specific key selection. And few minor comments: If this is not the first patch, please use [PATCH v3] instead of [PATCH]. And the fixes line is missed. Thanks Jingijng
