Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Friday, October 14, 2016 16:20 > To: Kulasek, TomaszX <tomaszx.kulasek at intel.com> > Cc: dev at dpdk.org; Ananyev, Konstantin <konstantin.ananyev at intel.com>; > olivier.matz at 6wind.com > Subject: Re: [dpdk-dev] [PATCH v5 1/6] ethdev: add Tx preparation > > 2016-10-14 14:02, Kulasek, TomaszX: > > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > > 2016-10-13 19:36, Tomasz Kulasek: > > > > +/** > > > > + * Fix pseudo header checksum for TSO and non-TSO tcp/udp packets > > > before > > > > + * hardware tx checksum. > > > > + * For non-TSO tcp/udp packets full pseudo-header checksum is > > > > + counted > > > and set. > > > > + * For TSO the IP payload length is not included. > > > > + */ > > > > +static inline int > > > > +rte_phdr_cksum_fix(struct rte_mbuf *m) > > > > > > You probably don't need this function since the recent improvements > > > from Olivier. > > > > Do you mean this improvement: "net: add function to calculate a checksum > in a mbuf" > > http://dpdk.org/dev/patchwork/patch/16542/ > > > > I see only full raw checksum computation on mbuf in Olivier patches, > while this function counts only pseudo-header checksum to be used with tx > offload. > > OK. Please check what exists already in librte_net (especially rte_ip.h) > and try to re-use code if possible. Thanks
I have already sent v6 with requested changes in Friday. There's no equivalent of rte_phdr_cksum_fix in librte_net. This function already uses rte_ipv4_phdr_cksum and rte_ipv6_phdr_cksum and there's nothing similar on the higher level to simplify it even more. Tomasz
