Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Thursday, October 13, 2016 21:21 > To: Kulasek, TomaszX <tomaszx.kulasek at intel.com> > Cc: dev at dpdk.org; Ananyev, Konstantin <konstantin.ananyev at intel.com> > Subject: Re: [PATCH v5 1/6] ethdev: add Tx preparation > > Hi, > > 2016-10-13 19:36, Tomasz Kulasek: > > Added API for `rte_eth_tx_prep` > > > > uint16_t rte_eth_tx_prep(uint8_t port_id, uint16_t queue_id, > > struct rte_mbuf **tx_pkts, uint16_t nb_pkts) > > > > Added fields to the `struct rte_eth_desc_lim`: > > > > uint16_t nb_seg_max; > > /**< Max number of segments per whole packet. */ > > > > uint16_t nb_mtu_seg_max; > > /**< Max number of segments per one MTU */ > > > > Created `rte_pkt.h` header with common used functions: > > Same comment as in previous revision: > this description lacks the usability and performance considerations. > > > +static inline uint16_t > > +rte_eth_tx_prep(uint8_t port_id __rte_unused, uint16_t queue_id > __rte_unused, > > + struct rte_mbuf **tx_pkts __rte_unused, uint16_t nb_pkts) > > Doxygen still do not parse it well (same issue as previous revision). > > > +/** > > + * Fix pseudo header checksum for TSO and non-TSO tcp/udp packets > before > > + * hardware tx checksum. > > + * For non-TSO tcp/udp packets full pseudo-header checksum is counted > and set. > > + * For TSO the IP payload length is not included. > > + */ > > +static inline int > > +rte_phdr_cksum_fix(struct rte_mbuf *m) > > You probably don't need this function since the recent improvements from > Olivier.
Do you mean this improvement: "net: add function to calculate a checksum in a mbuf" http://dpdk.org/dev/patchwork/patch/16542/ I see only full raw checksum computation on mbuf in Olivier patches, while this function counts only pseudo-header checksum to be used with tx offload. Tomasz
