On 05/13/2016 04:33 PM, David Marchand wrote: >> --- a/lib/librte_eal/common/include/rte_pci.h >> +++ b/lib/librte_eal/common/include/rte_pci.h >> @@ -105,7 +105,8 @@ extern struct pci_device_list pci_device_list; /**< >> Global list of PCI devices. >> /** Nb. of values in PCI resource format. */ >> #define PCI_RESOURCE_FMT_NVAL 3 >> >> -/** IO resource type: memory address space */ >> +/** IO resource type: */ >> +#define IORESOURCE_IO 0x00000100 >> #define IORESOURCE_MEM 0x00000200 >> >> /** > > This could go in a linux-specific header.
Yep, I'll do a separate patch for that in v2. > >> diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c >> b/lib/librte_eal/linuxapp/eal/eal_pci.c >> index 1a93725..f1ea52b 100644 >> --- a/lib/librte_eal/linuxapp/eal/eal_pci.c >> +++ b/lib/librte_eal/linuxapp/eal/eal_pci.c >> @@ -191,9 +191,9 @@ pci_find_max_end_va(void) >> } >> >> /* parse one line of the "resource" sysfs file (note that the 'line' >> - * string is modified) >> + * string is modified >> */ > > Garbage ? Indeed :) Thanks for reviewing!