On Thu, Apr 28, 2016 at 10:01:06AM +0800, Tan, Jianfeng wrote:
> >>+
> >>+ snprintf(vq_name, sizeof(vq_name), "port%d_%s%d",
> >>+ dev->data->port_id, queue_names[queue_type], queue_idx);
> >>+ vq = rte_zmalloc(vq_name, sizeof(struct virtqueue) +
> >>+ vq_size * sizeof(struct vq_desc_extra),
> >>+ RTE_CACHE_LINE_SIZE);
> >This is a cleanup, a good cleanup. So, make a patch for that, and do
> >NOT mix cleanup and fix in one single patch, which is something I
> >have told you quite few times, right?
>
> You mean submit a specific patch for cleanup or just another commit inside
> this patch set?
Do it as a patchset, as the two are connected: the fix should be based
on the cleanup patch.
--yliu
