On Tue, May 03, 2016 at 10:38:20PM -0700, Rasesh Mody wrote: > Change the Tx routine logic to ring the doorbell once per burst and not > on every Tx packet. This driver-level optimization is necessary to achieve > line rates for larger frame sizes (1k or more). > > Fixes: 540a211084a7 ("bnx2x: driver core") > > Signed-off-by: Rasesh Mody <rasesh.mody at qlogic.com> > Signed-off-by: Harish Patil <harish.patil at qlogic.com>
Hi Rasesh, Harish, there is quite a bit of churn to the tx_encap routine in this patch, but the reason for that function change is not really explained well here - why it's changed from a burst function to a single mbuf function. This is confusing when the overall objective of the patch seems to be to do the opposite - have things more burst oriented. It might be better to have this patch split into two patches - one changing the tx_encap function and then a second one to restructure the xmit function. Regards, /Bruce