On Tue, Jun 21, 2016 at 02:05:57PM +0200, Jan Medala wrote: > As requested, big patch splitted into logical pieces for easier review. > Improved style and fixed icc compiler issues. >
Thanks for the patch split. However, many of the patches don't have a commit message describing (at a high level), what the goal of that patch is and how it goes about implementing the changes to achieve that goal. Can you add a paragraph or two of commit message to each patch on the set to help anyone looking at the code understand what is happening in each patch. Regards, /Bruce > Jan Medala (6): > ena: update of ENA communication layer > ena: add debug area and host information > ena: disable readless communication regarding to HW revision > ena: allocate coherent memory in node-aware way > ena: fix memory management issue > ena: fix for icc compiler > > drivers/net/ena/base/ena_com.c | 254 +++++++------- > drivers/net/ena/base/ena_com.h | 82 +++-- > drivers/net/ena/base/ena_defs/ena_admin_defs.h | 107 +----- > drivers/net/ena/base/ena_defs/ena_eth_io_defs.h | 436 > ++++++------------------ > drivers/net/ena/base/ena_defs/ena_gen_info.h | 4 +- > drivers/net/ena/base/ena_eth_com.c | 32 +- > drivers/net/ena/base/ena_eth_com.h | 14 + > drivers/net/ena/base/ena_plat_dpdk.h | 42 ++- > drivers/net/ena/ena_ethdev.c | 275 ++++++++++++++- > drivers/net/ena/ena_ethdev.h | 40 +++ > 10 files changed, 675 insertions(+), 611 deletions(-) > > -- > 2.8.2 >
