> -----Original Message----- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > Sent: Tuesday, June 14, 2016 9:28 PM > To: Pattan, Reshma <reshma.pattan at intel.com> > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v9 5/8] pdump: add new library for packet > capturing support > > 2016-06-14 10:38, Reshma Pattan: > > The new librte_pdump library is added for packet capturing support. > > > > And more importantly, we need a doc in the prog guide. >
Hi Thomas, The Programmers Guide update is in another part of the patchset. Can we get some clarification on the requirements for documentation within patchset? Should all documentation related to a feature be in the patch for the feature? From your recent comments on patches it looks like that is the way you prefer it. That is fine but there is some confusion because it seems that wasn't always a requirement in the past so it would be best to clarify, and preferably document this. Also, it makes it a bit harder for the documentation maintainer (me in this case) to see doc changes within patches and to ack just the doc part. From a documentation maintainer point of view it would be best to have any, non-trivial, doc changes in a separate patch. John
