> -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, June 14, 2016 9:28 PM > To: Pattan, Reshma <reshma.pattan at intel.com> > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v9 5/8] pdump: add new library for packet > capturing support > > 2016-06-14 10:38, Reshma Pattan: > > The new librte_pdump library is added for packet capturing support. > > > > Added public api rte_pdump_init, applications should call this as part > > of their application setup to have packet capturing framework ready. > > > > Added public api rte_pdump_uninit to uninitialize the packet capturing > > framework. > > > > Added public apis rte_pdump_enable and rte_pdump_disable to enable and > > disable packet capturing on specific port and queue. > > > > Added public apis rte_pdump_enable_by_deviceid and > > rte_pdump_disable_by_deviceid to enable and disable packet capturing > > on a specific device (pci address or name) and queue. > > > > Added public api rte_pdump_set_socket_dir to set the server and client > > socket paths. > > Reshma, it is not the right info to put in a commit log. > The description of each function is in the doxygen comments. > We need to have the overview, what is the design architecture (rings, mempool, > etc) and why you do that?
Yes, I will update the commit message. > > > MAINTAINERS | 4 + > > config/common_base | 5 + > > lib/Makefile | 1 + > > lib/librte_pdump/Makefile | 55 ++ > > lib/librte_pdump/rte_pdump.c | 913 > +++++++++++++++++++++++++++++++++ > > lib/librte_pdump/rte_pdump.h | 216 ++++++++ > > lib/librte_pdump/rte_pdump_version.map | 13 + > > mk/rte.app.mk | 1 + > > And more importantly, we need a doc in the prog guide. > Yes the document is added, I will move the document change to this patch. Thanks, Reshma
